NAS-141238 / 25.10.5 / Do not poll network interface status in CLI menu (by themylogin) (by bugclerk)#134
Merged
Merged
Conversation
Author
yocalebo
approved these changes
Jun 22, 2026
Author
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
self._build_clistarts a loop that polls network interface unapplied changes status from middleware. This (and polling the terminal width) are the only background activities on an idling CLI menu. Let's postpone starting the polling thread until the TrueNAS CLI is actually requested.Original PR: #130
Original PR: #132